hashrocket / capybara-webmock

Mock external requests for Capybara JavaScript drivers
MIT License
51 stars 19 forks source link

Dependency on selenium-webdriver (~> 3.0) #44

Closed martinjozef closed 2 years ago

martinjozef commented 2 years ago

selenium-webdriver 3 series last update was in December 2019. https://rubygems.org/gems/selenium-webdriver/versions

Should capybara-webmock depend or at least allow usage of more recent release (~> 4.0) of selenium-webdriver ?

Here is an example of unmet dependency trying to keep up with more recent releases

* selenium-webdriver (~> 3.0), depended upon capybara-webmock-0.6.0, unsatisfied by selenium-webdriver-4.1.0
dillonhafer commented 2 years ago

I don't mind merging a PR and cutting a new release if you would like to PR it, but you don't have to.

dan-jensen commented 2 years ago

@dillonhafer here's a PR: https://github.com/hashrocket/capybara-webmock/pull/45

mvz commented 2 years ago

@dillonhafer could you please cut a new release that includes this dependency update?

pozabil commented 2 years ago

@dillonhafer Hello! I still can't install gem with bundler, cause it throws an error:

  In Gemfile:
    capybara-webmock (~> 0.6.0) was resolved to 0.6.0, which depends on
      selenium-webdriver (~> 3.0)

    webdrivers was resolved to 5.0.0, which depends on
      selenium-webdriver (~> 4.0)