search

hashrocket / capybara-webmock

Mock external requests for Capybara JavaScript drivers
MIT License
51 stars 19 forks source link

Still not working with selenium-webdriver 4.x, if installed with bundler #48

Open pozabil opened 2 years ago

pozabil commented 2 years ago

Hello! Related to https://github.com/hashrocket/capybara-webmock/issues/44 and https://github.com/hashrocket/capybara-webmock/pull/45, I'm trying to use bundler to install capybara-webmock gem, but I'm still getting the next error:

  In Gemfile:
    capybara-webmock (~> 0.6.0) was resolved to 0.6.0, which depends on
      selenium-webdriver (~> 3.0)

    webdrivers was resolved to 5.0.0, which depends on
      selenium-webdriver (~> 4.0)

How can I fix this?

mvz commented 1 year ago

It looks like the reason there is no new release is because the tests are failing. @dillonhafer is that correct?

I can't see the logs anymore, but I'm guessing the problem is that selenium-webdriver 4 does not support Ruby 2.5. There are two options:

  1. drop support for Ruby 2.5 (this seems the sensible solution)
  2. allow selenium-webdriver >= 3.0 and add a version check in the initalization code