search

hashrocket / decent_exposure

A helper for creating declarative interfaces in controllers
MIT License
1.81k stars 107 forks source link

Assign attributes when models are initialised #133

Closed brendon closed 8 years ago

brendon commented 8 years ago

Instead of assigning attributes after models have been initialised, we can supply the attributes to the initialisation routine.

A couple of tests have been updated to reflect the change.

brendon commented 8 years ago

Hi there, just remembered this pull request is outstanding. Was there any issue with it other than the need to rebase it?

mattpolito commented 8 years ago

Thanks for the contribution but am closing this as v3.0 is a different codebase

brendon commented 8 years ago

Thanks @mattpolito, are you aware off the top of your head if allowance was made for this approach in the rewrite?

mattpolito commented 8 years ago

The attributes are passed in to be initialized with the instance.

brendon commented 8 years ago

Very good :) I look forward to upgrading.