search

hashrocket / decent_exposure

A helper for creating declarative interfaces in controllers
MIT License
1.81k stars 107 forks source link

Example mailer code in README doesn't work #174

Open obie opened 7 years ago

obie commented 7 years ago

With Rails 5.0.0.1 not supplying id option to expose results in Decent Exposure expecting to have a params object available, which of course doesn't exist in mailers.

Since DE is able to hook into the execution chain between the mailer class and instance action method being invoked, it should be possible to use naming conventions to pluck the needed parameters automatically without need for additional boilerplate assignments.

Sorry, I don't have time to dig into the issue and provide a patch right now. But would love to mention DE in my Action Mailer chapter in The Rails 5 Way if possible.

jsncmgs1 commented 7 years ago

Sorry, resources are booked so likely won't be able to get to it in time for your book, but should you find the time, PR's welcome :)