search

hashtagchris / DotNet-BlueZ

A quick and dirty library for BlueZ's D-Bus APIs. Focus is on Bluetooth Low Energy APIs.
Apache License 2.0
103 stars 37 forks source link

Pull requests / updates? #24

Open hansmbakker opened 2 years ago

hansmbakker commented 2 years ago

Hi @hashtagchris, I was wondering whether you'd be willing to review the work that @gvheertum and @vestervang have been doing, and merge it?

I mean the caching PR (#15) and the commits in @vestervang's fork (https://github.com/hashtagchris/DotNet-BlueZ/compare/main...vestervang:DotNet-BlueZ:main)

I'd like to look into a dotnet 7 upgrade, and am wondering whether a PR would be accepted?

vestervang commented 2 years ago

Hi @hansmbakker i'm currently maintaining this fork as I use it at work. If you want to improve the library you can make a PR there and i'll have a look at it and push the changes to nuget.

hansmbakker commented 2 years ago

@vestervang great that you continued the work!

Please see some updates in https://github.com/ProrepubliQ/DotNet-BlueZ/pull/7

Could your repo somehow take over the "lead role" in the sense that the issue reporting is here but the most recent updates are in your repo?

aolszowka commented 1 year ago

So I've just cloned the repository that @vestervang holds, it looks like this was updated to .NET 7, not a huge deal but is there a reason we want to target that as opposed to netstandard like this upstream project does?

FWIW out of the box the current Ubuntu LTS (Jammy) does not have dotnet-sdk-7 in its default apt repos which is what I'm currently targeting.

I also noticed that the branch doesn't have the ability to open issues; do we want to still try an coordinate with this upstream project or do we want to attempt a hard fork?

EDIT: I went ahead and took the initiative to retarget the library itself back to netstandard2.0, upgraded the Tdms.DBus to the latest, and converted to dotnet-tool.json and opened https://github.com/vestervang/DotNet-BlueZ/pull/1 I ran a test with the scan app, but as I cannot see a way to validate my changes completely I'll have to assume they're OK. I'll continue making changes on that branch and targeting and coordinating here until I hear otherwise?

vestervang commented 1 year ago

Hi @aolszowka,

I have enabled issues on the repo now and there is no reason as far as i can see that we should target dotnet7 specifically.

aolszowka commented 1 year ago

Ok I am going to start coordinating work over there on that repository, please let me know if it becomes too much. I've got some free time today to grind this!