search

hashview / hashview-old

A web front-end for password cracking and analytics
http://www.hashview.io
GNU General Public License v3.0
619 stars 134 forks source link

Incorrect number of Dictionary Rules displayed in Tasks List #342

Closed GrepItAll closed 6 years ago

GrepItAll commented 6 years ago

If I click on the info icon next to the task 'English Dictionary + hob064 rules', Dictionary Rules is displayed as 7.

This is not correct, as there are 64 rules in this file.

If I click the info button next to a task using a ruleset I created with 75 rules, Dictionary Rules displays 30.

i128 commented 6 years ago

Can you provide a screenshot including the size for from the rules page (with the specific rules you're referring to). Can you also provide a second screen shot of the info page showing the wrong count?

For the hob064.rule, is this your own rule set, or one that came with hashview? Did you modify it at all? Did you create a task first, then modify the rule after it was created?

GrepItAll commented 6 years ago

This first screenshot shows the correct number of lines in hob064.rule:

correct_rule_count

This screenshot shows the erroneous count being displayed: incorrect_rule_count

This is the ruleset that came with Hashview and has not been changed at all. I have tried creating new tasks using this ruleset and the same thing happens

i128 commented 6 years ago

KK, isolated the issue. the number you're seeing isnt the number of rules, but rather the rule_id (the index number used for the rules table in the db). In fact, that row was never meant to show the rule count, but rather just the name of the rule assigned to the task. That said, i've updated the code in the dev branch to correctly show the name and rule count. image

GrepItAll commented 6 years ago

That's perfect, thanks for resolving that so quickly!

i128 commented 6 years ago

Closing, let me know if this comes back up.