Add quantization methods

hasindu2008 / sigtk

A simple toolkit for manipulating nanopore signal data

MIT License

18 stars 3 forks source link

Add quantization methods #6

Closed pasindumarasinghe closed 1 year ago

pasindumarasinghe commented 1 year ago

Implementation of quantization methods

The sigtk qts command now supports quantization methods. The --method option can be used to select the quantization method alongside with the -b flag.

--method=floor - truncate the LSBs specified by -b
--method=round - rounds off the value of the LSBs specified by -b to the nearest power of 2
--method=ceil - replaces the number of LSBs specified by -b with 1s.

hasindu2008 commented 1 year ago

Would you be able to send the pull request against the dev branch? I tend to first merge to this development branch and once tested only bring it to the main branch.

Also, I think filling ones is not really the ceil() right Perhaps we should use a different name - maybe fill-ones?

Could you please add this new option to the documentation under readme please.

I suggest making char *method = ""; to const char *method = "floor". Then the else part here https://github.com/hasindu2008/sigtk/pull/6/files#diff-f7494686b8c1d48ad9cdce8a65f3dc434d83e7bc407ca8b6dbabeff679630ed6R139 can be made to an error like "Unknown method for -m. Available options are x,y,z.

Thank you very much

pasindumarasinghe commented 1 year ago

Sure @hasindu2008. I'll make the changes.