search

haskell-CI / haskell-ci

Scripts and instructions for using CI services (e.g. Travis CI or Appveyor) with multiple GHC configurations
GNU General Public License v3.0
436 stars 71 forks source link

Don't require `head.hackage` for GHC 9.10 by default #725

Closed RyanGlScott closed 4 months ago

RyanGlScott commented 4 months ago

Currently, generating a CI job for GHC 9.10 will cause it to use head.hackage by default:

          if [ $((HCNUMVER >= 91000)) -ne 0 ] ; then echo "HEADHACKAGE=true" >> "$GITHUB_ENV" ; else echo "HEADHACKAGE=false" >> "$GITHUB_ENV" ; fi

This is a consequence of this code:

https://github.com/haskell-CI/haskell-ci/blob/07deeb7c38a0d9e69a5f6defdac3818764a9164e/src/HaskellCI/HeadHackage.hs#L7-L8

Now that GHC 9.10.1 is fully released, should this be changed so that 9.10.1 doesn't require head.hackage, just like other full GHC releases?

phadej commented 4 months ago

Ouch. Thanks for spotting this! I'll make a fix asap.