haskell-actions / run-fourmolu

Fourmolu GitHub Action
https://github.com/marketplace/actions/run-fourmolu
Other
9 stars 9 forks source link

Add to haskell/actions #11

Closed brandonchinn178 closed 1 year ago

brandonchinn178 commented 2 years ago

https://github.com/haskell/actions seems like it aims to be a monorepo of all Haskell-related GitHub actions. Maybe it'd be worthwhile to move code there, or otherwise link it?

ref. https://github.com/haskell/actions/issues/81

cdepillabout commented 2 years ago

https://github.com/haskell/actions seems like it aims to be a monorepo of all Haskell-related GitHub actions

Where are you seeing this? From taking a quick look at the repo, it looks like it only has hlint-related actions.

brandonchinn178 commented 2 years ago

Yes, it currently only has hlint-related actions, but the goal seems to be a monorepo: https://github.com/haskell/actions/issues/81#issuecomment-966653017

cdepillabout commented 2 years ago

or otherwise link it

I'm not sure what this would entail, but feel free to send a PR to https://github.com/haskell/actions. I'm not sure how much time we'd have to help with this, or to maintain code in https://github.com/haskell/actions.

brandonchinn178 commented 1 year ago

I have access to the new haskell-actions org. @cdepillabout if you're good with it, I can transfer fourmolu-action to haskell-actions/run-fourmolu, and keep you as admin for that repo. It'd be cool to get this action in the "official Haskell github actions" area

cdepillabout commented 1 year ago

@brandonchinn178 I don't have a strong opinion either way. Feel free to make the transfer if that makes the most sense! Oh, and can you make sure to add @wraithm as an admin as well?

If you do move fourmolu-action to that repo, maybe you could reach out to Mark (@mrkkrp) for https://github.com/mrkkrp/ormolu-action to see if he'd be interested in centralizing that as well.

brandonchinn178 commented 1 year ago

@cdepillabout done! I also renamed the repo so it reads more naturally: haskell-actions/run-fourmolu (it shouldn't break existing workflows, as GitHub should redirect appropriately. But I guess we'll see in a couple days). You should have admin access, but I forgot to give myself access; feel free to add me as an admin (or not, happy to keep my hands off)

cdepillabout commented 1 year ago

@brandonchinn178 Thanks! I've added you as an admin!

mrkkrp commented 1 year ago

Hey, I have just accepted the invitation to join haskell-actions! I'm very much in favor of transferring ormolu-action there. I can proceed with that immediately. Is there anything else I should do? Add @cdepillabout as an admin?

brandonchinn178 commented 1 year ago

I don't think you have to do anything, unless @cdepillabout wants to!

mrkkrp commented 1 year ago

Isn't https://github.com/haskell/actions the "official" repository for Haskell actions? https://github.com/haskell-actions seems to be mostly empty. I'm probably missing some context here...

mrkkrp commented 1 year ago

Where are you seeing this? From taking a quick look at the repo, it looks like it only has hlint-related actions.

https://github.com/haskell/actions also has setup which is what I use to setup Haskell in GitHub actions.

mrkkrp commented 1 year ago

I'm all for putting ormolu-action into some kind of official collection (and ideally not having to maintain it much), but haskell-actions doesn't look like one so far. I'm less keen on just moving things around without any benefit.

brandonchinn178 commented 1 year ago

@mrkkrp https://github.com/haskell/actions/issues/141#issuecomment-1496934773

mrkkrp commented 1 year ago

Okay that looks good. What about renaming? I'm not super convinced that run-ormolu is better than ormolu-action, but for consistency with run-fourmolu it's probably the best moment to rename it...

brandonchinn178 commented 1 year ago

Up to you 🤷

mrkkrp commented 1 year ago

Okay, I transferred it to haskell-actions as run-ormolu. I don't have admin rights though, so cannot add @cdepillabout as an admin. I imagine he is an admin by default anyway? It would be nice to also get admin rights on that repo to be able to maintain it if necessary.

brandonchinn178 commented 1 year ago

cc @andreasabel ^

mrkkrp commented 1 year ago

I will push a commit adjusting naming, etc. in run-ormolu a bit later today.

andreasabel commented 1 year ago

@mrkkrp I made you admin of your repo @haskell-actions (don't know why this is a manual step...)