search

haskell-bitcoin / bitcoin

Bitcoin Library for Haskell
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

first pass at cleaning out bch related code #11

Closed ProofOfKeags closed 1 year ago

ProofOfKeags commented 2 years ago

this PR addresses #1

It seems like there may be more things to do related to pulling out BCH related opcodes out of the script interpretation, however, iirc we may be moving the script interpreter out of the package altogether.

GambolingPangolin commented 1 year ago

An easy loose end to fix is getting rid of SIGHASH_FORKID (and decendents) and renaming txSigHashForkId to txSigHashSegwitV0 or something.

ProofOfKeags commented 1 year ago

An easy loose end to fix is getting rid of SIGHASH_FORKID (and decendents) and renaming txSigHashForkId to txSigHashSegwitV0 or something.

Good catch. I knew I was gonna miss something cause I didn't comb through all of the code scrutinizing things that don't exist in BTC. I'll remove that here.

ProofOfKeags commented 1 year ago

all comments addressed