search

haskell-bitcoin / bitcoin

Bitcoin Library for Haskell
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Add build github workflow #34

Closed tochicool closed 1 year ago

tochicool commented 1 year ago

Attempt to resolve #30.

The workflow builds and runs the tests on ubuntu, macOS and windows after installing libsecp256k1. It's adapted from this workflow of a project with a libsecp256k1 runtime dependency. We can remove windows and macOS from the build matrix or move libsecp256k1 to a submodule if preferred.

ProofOfKeags commented 1 year ago

Thanks for the patch!

I like having all 3 workflows for now. I don't see a reason to ditch it unless we run into some resource limit from GitHub. I'm fine fixing that once it proves to be an issue though.

As for libsecp, we have plans to move to the new version I put out libsecp256k1-0.1.0 in the 0.1.0 release. We could submodule it, but for now I like the idea of pinning actual versions to minimize the need to release them together. Given that libsecp256k1 is a much more general tool than bitcoin, it would be a shame to force them into a codevelopment workflow.