search

haskell-bitcoin / bitcoin

Bitcoin Library for Haskell
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Split test and bench out to separate packages #43

Closed wraithm closed 1 year ago

wraithm commented 1 year ago

https://github.com/haskell-bitcoin/bitcoin/issues/42

GambolingPangolin commented 1 year ago

The packaging is not very clear from the directory structure. How about reorganizing the code so that there are three folders, each of which contains a package?:

In addition, we can keep README.md, stack.yaml, etc. at the top level.

wraithm commented 1 year ago

The packaging is not very clear from the directory structure. How about reorganizing the code so that there are three folders, each of which contains a package?:

  • bitcoin
  • bitcoin-test
  • bitcoin-bench

In addition, we can keep README.md, stack.yaml, etc. at the top level.

I'm not opposed to that at all.

@ProofOfKeags, what do you think?

ProofOfKeags commented 1 year ago

100% onboard with that folder structure.

ProofOfKeags commented 1 year ago

After reviewing as well I'm fine to merge this after exposing internal modules and reorganizing the directories to be more intuitive.

wraithm commented 1 year ago

@ProofOfKeags @GambolingPangolin This is ready for review.