haskell-crypto / cryptonite

lowlevel set of cryptographic primitives for haskell
Other
226 stars 139 forks source link

failure on arm64 #234

Closed clinty closed 6 years ago

clinty commented 6 years ago
      1:                                 test-cryptonite: cbits/decaf/ed448goldilocks/decaf.c:1267: cryptonite_decaf_448_point_decode_like_eddsa_and_ignore_cofactor: Assertion `API_NS(point_valid)(p) || ~succ' failed.

https://buildd.debian.org/status/fetch.php?pkg=haskell-cryptonite&arch=arm64&ver=0.25-2&stamp=1523959743&raw=0

ocheron commented 6 years ago

I don't have what is necessary to reproduce unfortunately. Can you test adding the architecture to the following line, to enable 64-bit decaf code? https://github.com/haskell-crypto/cryptonite/blob/ec8366bbd27b58eb221293d4a6b3f75c78c14f92/cryptonite.cabal#L272

clinty commented 6 years ago

Builds and tests pass with

if arch(x86_64) || arch(aarch64)

on both the decaf and donna

https://buildd.debian.org/status/fetch.php?pkg=haskell-cryptonite&arch=arm64&ver=0.25-3&stamp=1524524651&raw=0

ocheron commented 6 years ago

Thanks for testing. I committed the changes.