search

haskell-distributed / distributed-process-client-server

Cloud Haskell - gen_server implementation
http://haskell-distributed.github.io
BSD 3-Clause "New" or "Revised" License
13 stars 11 forks source link

Fix extra-deps #22

Closed tdietert closed 6 years ago

tdietert commented 6 years ago

This PR points to the commit hashes that include the dependency bounds fixes in the dependencies for this package.

This PR also refactors Test.Utils to use the latest version of network-transport and network-transport-tcp.

tdietert commented 6 years ago

I'm not sure of the policy on pointing to git commits, but until the packages get into a reproducible build plan, this is kind of the best we can do.

You will notice the CI failures on the last PR merged that "fixed" these deps; I think this PR will build clean.

tdietert commented 6 years ago

Well then... any tips on getting this to pass CI? It builds properly on my machine, and all the tests pass... however, none of the CI builds pass.

qnikst commented 6 years ago

@tdietert let me try to fix CI errors on your branch. I'll try to add older ghc support back.

qnikst commented 6 years ago

@tdietert I've pushed, it worked locally for me. If it passes CI, I'll bump revision and push that to hackage as well.

tdietert commented 6 years ago

woot :tada: awesome, thanks!

qnikst commented 6 years ago

You welcome! I think I'll not add back older versions unless it will be requested or there is a demand from people using those versions in it's own installations. As that would require a lot of maintenance burden. When 8.6 will out, I'll keep support for 8.4 though.