remove ambiguity b/t Supervisor/Child/Starter PIDs

haskell-distributed / distributed-process-platform

DEPRECATED (Cloud Haskell Platform) in favor of distributed-process-extras, distributed-process-async, distributed-process-client-server, distributed-process-registry, distributed-process-supervisor, distributed-process-task and distributed-process-execution

http://haskell-distributed.github.com

BSD 3-Clause "New" or "Revised" License

47 stars 17 forks source link

remove ambiguity b/t Supervisor/Child/Starter PIDs #89

Closed tavisrudd closed 10 years ago

tavisrudd commented 10 years ago

use SupervisorPid, ChildPid, StarterPid type aliases rather than ambiguous ProcessId
rename uses of pid as an expr name to childPid or sup

Ideally all internal bits of Supervisor would use phantom types to make this a type level rather than name based distinction. This is a first step towards that goal.

tavisrudd commented 10 years ago

Sorry, in my raising a newborn / sleep-deprived state I managed to miss a hunk on the first commit. You'll want to squash these commits together.

tavisrudd commented 10 years ago

@hyperthunk have you seen this SupervisorTest case fail ephemerally before? I can't replicate it locally. https://travis-ci.org/haskell-distributed/distributed-process-platform/jobs/24319462#L1111

ExitShutdown Is Considered Normal (Closure): [Failed]

unexpected child ref: ("transient-worker",Just (ChildRunning pid://127.0.0.1:8080:0:141,ChildSpec {childKey = "transient-worker", childType = Worker, childRestart = Transient, childStop = TerminateImmediately, childStart = RunClosure (Closure (Static (StaticApply (StaticLabel "$const") (StaticLabel "Main.blockIndefinitely"))) ""), childRegName = Nothing}))

hyperthunk commented 10 years ago

@tavisrudd - I haven't seen that one for a while now, but IIRC I did see it previously. I'll have to dig into it.