search

haskell-distributed / distributed-process

Cloud Haskell core libraries
http://haskell-distributed.github.io
711 stars 96 forks source link

Fix builds with GHC 8.8.1 and newer `hashable`. #344

Closed patrickt closed 3 years ago

patrickt commented 4 years ago

hashable is up to 1.3 and fail is no longer a part of Monad.

patrickt commented 4 years ago

Not clear to me why the unit tests are failing: it looks like a Stack issue, which is puzzling, as I didn’t change the stack.yml in any way.

jwaldmann commented 4 years ago

This patch only works for ghc-8.8? I get

cabal --with-ghc=/opt/ghc/ghc-8.6.5/bin/ghc build
...
src/Control/Distributed/Process/Internal/Types.hs:356:14: error:
    Not in scope: type constructor or class ‘MonadFail’

I think this can be repaired with an extra

import Control.Monad.Fail (MonadFail)

Then it compiles with ghc-8.4, 8.6. 8.8.

patrickt commented 4 years ago

Oop! Good catch. My apologies; fixing.

patrickt commented 4 years ago

Still getting a Stack error from the builders, though I’ve verified it’s good on 8.4-8.8 with ghcup and cabal install. Will investigate further.

alexbiehl commented 4 years ago

@patrickt your patch is fine. I think stack 2 snuck in somehow. https://github.com/haskell-distributed/distributed-process/pull/342 has the cure.

AJChapman commented 4 years ago

Is there anything currently stopping this PR from being merged? Does it just need to be rebased against master? I'd like to see it merged as this issue is breaking my build on Nix.

joelmccracken commented 3 years ago

closed via #361