Closed avieth closed 7 years ago
Will review tomorrow, since I probably need this to make my PR for haskell-distributed/distributed-process#439 work.
PR looks good to me (modulo minor nitpick). One thing that worry me a bit is if we should have extended function in exposeInternals or always? Pros of hiding:
LGTM. I don't mind adding parameters to createTransport
. @qnikst do you want to do something about it before we merge?
@dcoutts, do you want to hold merging until you give it a look?
Everything looks ok to me.
Can compute the external address and port (a part of the
EndPointAddress
) from the chosen bind port. That's useful in case you choose "0" as the bind port, in which case the OS will choose one for you.