Separate bind address - Githubissues

haskell-distributed / network-transport-tcp

TCP Realisation of Network.Transport

http://haskell-distributed.github.com

BSD 3-Clause "New" or "Revised" License

30 stars 27 forks source link

Separate bind address #50

Closed avieth closed 7 years ago

avieth commented 7 years ago

Can compute the external address and port (a part of the EndPointAddress) from the chosen bind port. That's useful in case you choose "0" as the bind port, in which case the OS will choose one for you.

dcoutts commented 7 years ago

Will review tomorrow, since I probably need this to make my PR for haskell-distributed/distributed-process#439 work.

qnikst commented 7 years ago

PR looks good to me (modulo minor nitpick). One thing that worry me a bit is if we should have extended function in exposeInternals or always? Pros of hiding:

backward compatibility is preserved
users do not need to learn scary thing and have complex common case Cons of:
we hide actual functionality from user, so he may never know that it exists, even if he needs it.

facundominguez commented 7 years ago

LGTM. I don't mind adding parameters to createTransport. @qnikst do you want to do something about it before we merge?

facundominguez commented 7 years ago

@dcoutts, do you want to hold merging until you give it a look?

qnikst commented 7 years ago

Everything looks ok to me.