search

haskell-distributed / network-transport-tcp

TCP Realisation of Network.Transport
http://haskell-distributed.github.com
BSD 3-Clause "New" or "Revised" License
30 stars 27 forks source link

Docs lie about default value of TCP_NODELAY #62

Closed nh2 closed 1 month ago

nh2 commented 7 years ago

https://github.com/haskell-distributed/network-transport-tcp/blob/6757ce91eeb3fe67cde33f1f2178e090f8348345/src/Network/Transport/TCP.hs#L477

    -- | Should we set TCP_NODELAY on connection sockets?
    -- Defaults to True.
    , tcpNoDelay :: Bool

https://github.com/haskell-distributed/network-transport-tcp/blob/6757ce91eeb3fe67cde33f1f2178e090f8348345/src/Network/Transport/TCP.hs#L615

defaultTCPParameters = TCPParameters {
 ...
, tcpNoDelay = False

This inconsistency was introduced in https://github.com/haskell-distributed/network-transport-tcp/commit/859a1ade2331803d64daf9e9c011b3f2c9c2608b.

LaurentRDC commented 1 month ago

Fixed in 456f406 and release 0.8.4