search

haskell-distributed / network-transport-tcp

TCP Realisation of Network.Transport
http://haskell-distributed.github.com
BSD 3-Clause "New" or "Revised" License
30 stars 25 forks source link

Change tcpNoDelay default to be the same as TCP_NODELAY. #8

Closed facundominguez closed 9 years ago

facundominguez commented 9 years ago

@mboes points out that it is less surprising to the user if we use the same defaults as the TCP layer, which I think makes sense.

nh2 commented 7 years ago

@facundominguez What did you mean with the same as TCP_NODELAY - which TCP_NODELAY are you referring to here, the default setting of the network package?

facundominguez commented 7 years ago

We assume the OS does not enable the TCP_NODELAY option on new sockets. If this is not the case across platforms, we could make it an option of type Maybe Bool instead.

nh2 commented 7 years ago

OK, thanks for explaining.

By now I think that enabling nodelay might be a better default for network-transport-tcp given that it is pipelining multiple connections over a single one, but that's a different topic, I may open another issue to discuss that in the future.