search

haskell-fswatch / hfsnotify

Unified Haskell interface for basic file system notifications
BSD 3-Clause "New" or "Revised" License
136 stars 40 forks source link

Fixes openFile invocation in test suite #106

Closed jkachmar closed 1 year ago

jkachmar commented 1 year ago

Test suite fails to compile as-is; if you want to use the lifted openFile from unliftio i believe you need to import UnliftIO.IO (openFile).

thomasjm commented 1 year ago

Tests are compiling fine on all the tested GHCs in CI (except for some other problems). What's your setup?

jkachmar commented 1 year ago

i'm building this with a custom nixpkgs snapshot; it's possible that there's some out-of-date library on my end though.

where is openFile meant to come from for you? when i looked on Hackage it seemed like it mainly- ah i see the issue. my package set is using unliftio-0.2.19 and the lifted openFile was only added in 0.2.20.

it might be worthwhile to add a lower bound on unliftio >= 0.2.20 then; either way not the problem i thought it was!

thomasjm commented 1 year ago

Oh gotcha -- lower bounded added in 0dbf227551c346c23f079251363617980d481944