Closed thomasjm closed 6 years ago
Hey Tom, thanks for your work.
Unfortunately, there doesn't seem to be any active maintainers to review your code.
However, the package does need a new maintainer. Would you be willing to become one?
Hi @feuerbach -- yes! I'd be happy to.
Great! I already invited you as a committer to this github org. If you let me know your hackage username, I'll also grant you the upload rights.
Thanks -- Hackage username is thomasjm
Done!
Sweet, I'll turn this PR into a new major version release soon
Hi,
I've been giving this library some love for a while and was wondering if you would be interesting in merging this stuff back. Changes include
-- Detect directory creation/deletion (addresses #71) -- Test suites passing on Travis/Appveyor on Windows, Linux, and Mac and test stability improved (should fix #62) -- Improve a race condition when adding watches on Linux (because adding the watch takes some amount of time, it can miss files created while the watch was being created) (should fix #67) -- Make things more sane on Mac, where FSEvents flags can be unpredictable (the situation in #69 is significantly improved as well as #36). -- I believe issue #66 is fixed also.
This is a big collection of changes, so I'm open to feedback about what you want to do with it. A couple other notes:
-- There's a breaking API change;
Event
s now have anisDirectory
flag, soAdded FilePath UTCTime
becomesAdded FilePath UTCTime Boolean
-- On Windows I needed to adjust the flags being passed toReadDirectoryChangesW
, so I modified thewin32-notify
module so flags can be passed directly. That module is currently a git submodule in my branch. (Honestly I think it should just be copied intohfsnotify
; it's only 2 files.)Best, Tom