search

haskell-fswatch / hfsnotify

Unified Haskell interface for basic file system notifications
BSD 3-Clause "New" or "Revised" License
136 stars 40 forks source link

Support hinotify master #75

Closed avieth closed 6 years ago

avieth commented 6 years ago

hinotify now uses ByteString rather than [Char] for file paths (RawFilePath).

https://github.com/kolmodin/hinotify/issues/19 https://github.com/kolmodin/hinotify/commit/106930cae1bc8dc8ab6041816c11eafa72387cfe

Somehow this didn't make it into the changelog for that package. because it's not yet released :)

jchia commented 6 years ago

hinotify switched to RawFilePath in 11c4d31a95ad36f954fac6728e47042a92e4466a, quite a while ago, and there was a new hackage release a few days ago that uses RawFilePath. Previously, it was using GHC.IO.Encoding.getFileSystemEncoding together with GHC.Foreign.withCString to convert from ByteString to FilePath. Now that hinotify is no longer doing that decoding, should hsnotify start doing it for newer versions of hinotify?

In short, what is to be done about the filename encoding?

This issue is blocking the inclusion of fsnotify in stackage nightly.