search

haskell-fswatch / hfsnotify

Unified Haskell interface for basic file system notifications
BSD 3-Clause "New" or "Revised" License
136 stars 40 forks source link

Add compatibility with hinotify-0.3.10 #77

Closed 4e6 closed 6 years ago

4e6 commented 6 years ago

close #75

From the ticket discussion:

hinotify switched to RawFilePath in 11c4d31a95ad36f954fac6728e47042a92e4466a

I looked into the commit https://github.com/kolmodin/hinotify/commit/11c4d31a95ad36f954fac6728e47042a92e4466a and implemented the conversions from/to ByteString that previously were done by hinotify. So the logic should've stayed the same

simonmichael commented 6 years ago

Ping ? If this could be merged and released, it would help me out in the hledger project.

borsboom commented 6 years ago

I think this is the very last dependency blocking Stack from being build with GHC 8.4.

UnkindPartition commented 6 years ago

Hey there,

Sorry for the silence — I don't really have time to maintain this package and must've unsubscribed from the notifications at some point. I'll merge and release this PR (thanks for writing the patch, Dmitry!), and then will look for a new maintainer and/or home for this project.

Does anyone here want to step in as an active maintainer by any chance?

UnkindPartition commented 6 years ago

This is now released as fsnotify-0.2.1.2.

borsboom commented 6 years ago

Thank you!

simonmichael commented 6 years ago

Thanks @feuerbach. https://github.com/fpco/stackage/blob/master/build-constraints.yaml can now be updated too, re-enabling all packages marked with "via hinotify" or "via fsnotify". Or if you'd prefer, I can submit the PR.

simonmichael commented 6 years ago

https://github.com/fpco/stackage/pull/3548