Build failure on Windows

[snoyberg]

I was testing the new 0.3.0.0 release on Windows, and I got the following build failure:

    Preprocessing library for fsnotify-0.3.0.0..
    Building library for fsnotify-0.3.0.0..
    [1 of 7] Compiling System.FSNotify.Path ( src\System\FSNotify\Path.hs, .stack-work\dist\7d103d30\build\System\FSNotify\Path.o )
    [2 of 7] Compiling System.FSNotify.Types ( src\System\FSNotify\Types.hs, .stack-work\dist\7d103d30\build\System\FSNotify\Types.o )
    [3 of 7] Compiling System.FSNotify.Listener ( src\System\FSNotify\Listener.hs, .stack-work\dist\7d103d30\build\System\FSNotify\Listener.o )
    [4 of 7] Compiling System.FSNotify.Polling ( src\System\FSNotify\Polling.hs, .stack-work\dist\7d103d30\build\System\FSNotify\Polling.o )

    C:\Users\Michael Snoyman\AppData\Local\Temp\stack1764\fsnotify-0.3.0.0\src\System\FSNotify\Polling.hs:64:17: warning: [-Wname-shadowing]
        This binding for `path' shadows the existing binding
          bound at src\System\FSNotify\Polling.hs:58:22
       |
    64 |     pathAndInfo path = handle (\(_ :: IOException) -> return Nothing) $ do
       |                 ^^^^
    [5 of 7] Compiling System.FSNotify.Win32 ( src\System\FSNotify\Win32.hs, .stack-work\dist\7d103d30\build\System\FSNotify\Win32.o )

    C:\Users\Michael Snoyman\AppData\Local\Temp\stack1764\fsnotify-0.3.0.0\src\System\FSNotify\Win32.hs:62:34: error:
        Not in scope: `WNo.fILE_NOTIFY_CHANGE_FILE_NAME'
        Module `System.Win32.Notify' does not export `fILE_NOTIFY_CHANGE_FILE_NAME'.
       |
    62 |   let fileFlags = foldl (.|.) 0 [WNo.fILE_NOTIFY_CHANGE_FILE_NAME, WNo.fILE_NOTIFY_CHANGE_SIZE, WNo.fILE_NOTIFY_CHANGE_ATTRIBUTES]
       |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

    C:\Users\Michael Snoyman\AppData\Local\Temp\stack1764\fsnotify-0.3.0.0\src\System\FSNotify\Win32.hs:62:68: error:
        Not in scope: `WNo.fILE_NOTIFY_CHANGE_SIZE'
        Module `System.Win32.Notify' does not export `fILE_NOTIFY_CHANGE_SIZE'.
       |
    62 |   let fileFlags = foldl (.|.) 0 [WNo.fILE_NOTIFY_CHANGE_FILE_NAME, WNo.fILE_NOTIFY_CHANGE_SIZE, WNo.fILE_NOTIFY_CHANGE_ATTRIBUTES]
       |                                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^

    C:\Users\Michael Snoyman\AppData\Local\Temp\stack1764\fsnotify-0.3.0.0\src\System\FSNotify\Win32.hs:62:97: error:
        Not in scope: `WNo.fILE_NOTIFY_CHANGE_ATTRIBUTES'
        Module `System.Win32.Notify' does not export `fILE_NOTIFY_CHANGE_ATTRIBUTES'.
       |
    62 |   let fileFlags = foldl (.|.) 0 [WNo.fILE_NOTIFY_CHANGE_FILE_NAME, WNo.fILE_NOTIFY_CHANGE_SIZE, WNo.fILE_NOTIFY_CHANGE_ATTRIBUTES]
       |                                                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

    C:\Users\Michael Snoyman\AppData\Local\Temp\stack1764\fsnotify-0.3.0.0\src\System\FSNotify\Win32.hs:63:33: error:
        Not in scope: `WNo.fILE_NOTIFY_CHANGE_DIR_NAME'
        Module `System.Win32.Notify' does not export `fILE_NOTIFY_CHANGE_DIR_NAME'.
       |
    63 |   let dirFlags = foldl (.|.) 0 [WNo.fILE_NOTIFY_CHANGE_DIR_NAME]
       |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[thomasjm]

Oops, it's the dependency on the separate win32-notify package. This was a git submodule but obviously that didn't help when I uploaded to Hackage. I'm going to just absorb that code into fsnotify, will release 0.3.0.1 with the fix as soon as I make sure it doesn't break anything.

[snoyberg]

Awesome, thanks!

On Tue, May 29, 2018, 1:48 PM Tom McLaughlin notifications@github.com wrote:

Oops, it's the dependency on the separate win32-notify package. This was a git submodule but obviously that didn't help when I uploaded to Hackage. I'm going to just absorb that code into fsnotify, will release 0.3.0.1 with the fix as soon as I make sure it doesn't break anything.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/haskell-fswatch/hfsnotify/issues/80#issuecomment-392734255, or mute the thread https://github.com/notifications/unsubscribe-auth/AADBB4V4wcFwk-3ytKVEfRjKRSs8Yc4Qks5t3SdxgaJpZM4URLT_ .

[thomasjm]

CI builds look good, upload done.