search

haskell-github-trust / ekg-statsd

Flush system metrics to statsd
BSD 3-Clause "New" or "Revised" License
26 stars 23 forks source link

Replace ':'s in metric name by '_' #26

Closed roberth closed 4 years ago

roberth commented 4 years ago

This allows ekg-statsd to be used with servant-ekg, which generates metrics like

servant.path.accounts.:accountId.GET.time_ms.max:113.571281|g

So, having a colon in the metric name, terminating the name part too early. Both StatsD and Dogstatsd behave like this.

23Skidoo commented 4 years ago

Shouldn't this be documented somewhere?

roberth commented 4 years ago

One would hope to find documentation about such a format, but I had to look at the source to determine the behavior. As for documenting it here, I guess that would be nice. I'll add something to the module haddock.

roberth commented 4 years ago

This PR is ready for review.

23Skidoo commented 4 years ago

Merged, thanks!