haskell-github / github

The github API for Haskell
https://hackage.haskell.org/package/github
BSD 3-Clause "New" or "Revised" License
410 stars 191 forks source link

Undocumented features from GitHub Enterprise #416

Open robbiemcmichael opened 4 years ago

robbiemcmichael commented 4 years ago

GitHub Enterprise supports additional features which don't seem to be documented in the public API. As a concrete example, there is an ldap_dn field for teams which allows their membership to be linked to an LDAP group, but unfortunately the field isn't listed in the docs for teams.

A couple of questions to clarify the intent of this library:

phadej commented 4 years ago

If the GitHub Enterprise features are documented somewhere, then I'm ok with supporting them.

EDIT: I'd expect that enterprise features are the ones which are documented well.

robbiemcmichael commented 4 years ago

Looks like they have separate documentation for the enterprise features, e.g. the ldap_dn field is documented here. I'll raise a PR for adding support for this field so we can have a concrete example of what it looks like and have the debate there for whether it's confusing for non-enterprise users.