haskell-github / github

The github API for Haskell
https://hackage.haskell.org/package/github
BSD 3-Clause "New" or "Revised" License
411 stars 190 forks source link

Release a version for GHC 9.0 to hackage #460

Closed andreasabel closed 3 years ago

andreasabel commented 3 years ago

It seems that some work has already done migrating this to GHC 9.0, would be great to see a release on hackage...

Atm, I am getting a compilation error with --allow-newer:

[78 of 79] Compiling GitHub.Request   ( src/GitHub/Request.hs, dist/build/GitHub/Request.o, dist/build/GitHub/Request.dyn_o )

src/GitHub/Request.hs:510:18: error:
    • Expecting one more argument to ‘Link’
      Expected a type, but ‘Link’ has kind ‘* -> *’
    • In the type signature: isRelNext :: Link -> Bool
      In an equation for ‘getNextUrl’:
          getNextUrl req
            = do linkHeader <- lookup "Link" (responseHeaders req)
                 links <- parseLinkHeaderBS linkHeader
                 nextURI <- find isRelNext links
                 ....
            where
                isRelNext :: Link -> Bool
                isRelNext = any (== relNextLinkParam) . linkParams
                relNextLinkParam :: (LinkParam, Text)
                relNextLinkParam = (Rel, "next")
    |
510 |     isRelNext :: Link -> Bool
    |                  ^^^^

This seems to be fixed by https://github.com/phadej/github/commit/514b175851dd7c4a9722ff203dd6f652a15d33e8 already, though.

domenkozar commented 3 years ago

This also breaks for LTS-18.2 /cc @phadej

andreasabel commented 3 years ago

A revision relaxing base should now be possible, see https://github.com/phadej/github/pull/456#issuecomment-907219374.

andreasabel commented 3 years ago

ping Hackage maintainers: @phadej @jwiegley @mxswd @mike-burns @nataren

phadej commented 3 years ago

https://hackage.haskell.org/package/github-0.27 released