search

haskell-graphql / graphql-api

Write type-safe GraphQL services in Haskell
BSD 3-Clause "New" or "Revised" License
406 stars 35 forks source link

Drop generated cabal files from git tracking #144

Closed sunwukonga closed 6 years ago

sunwukonga commented 6 years ago

Can I drop:

docs/source/tutorial/tutorial.cabal
graphql-wai/graphql-wai.cabal

from tracked and add them to .gitignore ?

jml commented 6 years ago

No strong objection. They are there for people who don’t want to use hpack / stack.

Why do you want to remove them? On Wed, 3 Jan 2018 at 23:40, Paul Desmond Parker notifications@github.com wrote:

Can I drop:

docs/source/tutorial/tutorial.cabal graphql-wai/graphql-wai.cabal

from tracked and add them to .gitignore ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jml/graphql-api/issues/144, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHq6k7c6-h5eIvPafnZ12lbY2Dy4ngmks5tHA_9gaJpZM4RSZpm .

sunwukonga commented 6 years ago

I use hpack and I haven't been commiting the cabal files because they are generated. I could have added them to commits, but it didn't feel right.

I see your point, some people may not be using hpack. Though if such a person were to contribute, it might be a problem when everyone else's stack automatically overwrites the new cabal files with config generated from the "then" out-of-date package.yaml.

sunwukonga commented 6 years ago

I'll commit the cabal files in future. It lowers the bar to entry into the code.