Reduce operation type repetition

haskell-graphql / graphql-api

Write type-safe GraphQL services in Haskell

BSD 3-Clause "New" or "Revised" License

406 stars 35 forks source link

Reduce operation type repetition #212

Closed thiagorp closed 5 years ago

thiagorp commented 5 years ago

This PR makes the operation type as a parameter of the Operation data constructor as suggested on the comment.

thiagorp commented 5 years ago

I am happy to be able to help a little bit 😄

teh commented 5 years ago

I got confused by the github interface and merged master into this branch instead of the other way round. @thiagorp you OK with me cherry-picking your changes into master? Alternatively if you want to go with the PR would you mind creating a new one? There doesn't seem to be a way of backing out the merge..

thiagorp commented 5 years ago

Hey @teh, I am ok with both options. I will create a new PR now so in case you prefer this approach you are not blocked by me. But feel free to also cherry-pick if you find it better.