haskell-graphql / graphql-api

Write type-safe GraphQL services in Haskell
BSD 3-Clause "New" or "Revised" License
406 stars 35 forks source link

WIP: Full value roundtrip #38

Closed jml closed 7 years ago

jml commented 7 years ago

37 does this for strings, this does it for all values. Review & merge #37 first to see a good diff for this.

Adds quickcheck tests for roundtripping values. They currently fail, but not on every run. I've added a test that exercises the broken path, but I haven't had time to minimize.

It might be useful to begin by adding better shrinking support to the Arbitrary instances we already have. That's what I'm going to do next time I face quickcheck failures.

jml commented 7 years ago

LGTM. I think you have to approve.