haskell-graphql / graphql-api

Write type-safe GraphQL services in Haskell
BSD 3-Clause "New" or "Revised" License
406 stars 35 forks source link

Guaranteed correct name in AST #42

Closed jml closed 7 years ago

jml commented 7 years ago

New TODOs:

src/GraphQL/API.hs:
  -- TODO(jml): Given that AnnotatedType is parametrised, we can probably reduce
  -- a great deal of duplication by making HasAnnotatedType a parametrised type
  -- class.

src/GraphQL/API.hs:
  -- TODO(jml): Be smarter and figure out how to say "all integral types" rather
  -- than listing each individually.

src/GraphQL/Server.hs:
  -- TODO(jml): I don't understand why I can't extract (Object typeName interfaces fields)
  -- from this Union instance as I did for the above Union instance.
jml commented 7 years ago

Should point out that you can tell where we can use more structure in error type by searching for formatNameError.

jml commented 7 years ago

Build failure is CircleCI being buggy.

In the end I've made very few changes because I'm not clear what the actionable feedback is.

teh commented 7 years ago

Survived Christmas :)

Can I merge this?

jml commented 7 years ago

Merged. Sorry for the delay.