haskell-graphql / graphql-api

Write type-safe GraphQL services in Haskell
BSD 3-Clause "New" or "Revised" License
406 stars 35 forks source link

Rename 'buildResolver' #71

Closed jml closed 7 years ago

jml commented 7 years ago

Naming something to imply that it'll get used partially sometimes is not very Haskell.

e.g. it's map, not buildMapper. it's filter, not buildFilterer.

I suggest execute or resolve, or something similarly direct.

teh commented 7 years ago

maybe we should rename HasGraph to HasResolver as well? I think I prefer resolve because that's what most of the JS libraries are using. No need to be special for this particular name.

teh commented 7 years ago

(though execute would be fine as well of course, considering that the spec calls it "execution")

jml commented 7 years ago

+1 for HasResolver and resolve