search

haskell-grpc-native / http2-client

A native HTTP2 client in Haskell
BSD 3-Clause "New" or "Revised" License
43 stars 27 forks source link

Fix build for GHC-9.0 #83

Closed tvh closed 6 months ago

ProofOfKeags commented 2 years ago

Actually, as I said in the earlier comment, this will not work.

You can see here: https://hackage.haskell.org/package/http2-3.0.2

http2 has a module called Network.HTTP2.Client which interferes with the Network.HTTP2.Client exported by this library. As such they will never really be compatible. I'm actually somewhat surprised that your tests showed that this would work. Have you tried pulling in http2-client into another project with these changes?

ProofOfKeags commented 2 years ago

Yes, but I am also using PackageImports. See memrange/push-notify-apn@c93cacb.

Making this change will essentially turn -XPackageImports into a required extension for use with this lib. I am not tremendously upset about that. But I'm also only a recent maintainer of the package. If I can get a signoff from @lucasdicioccio or examples of other widely used libraries that have bit the bullet with this particular issue, then I'm happy to merge.

ethercrow commented 2 years ago

I use this library and am completely fine with embracing -XPackageImports.

lucasdicioccio commented 6 months ago

Closing as we seem to have a working 9.x build now (e.g., 9.8 with #92), thanks for all involved and apologies for the glacially-slow time to update.