Open parsonsmatt opened 1 year ago
This explains something I've run into I think. Thanks for catching it. If you want to do a PR I can merge it ASAP. Otherwise I'll see if I can get to it tonight. Haven't worked on this for a bit now so need to get it set up otherwise I'd do it now.
oh good catch! your patch proposition should work
I'll try something over a lunch next week.
It's possible for the
_close
to never be called in the event of an exception. These lines of code are especially problematic:Fortunately the fix should be relatively straightforward - doing
mainHandler client `finally` _close client
should fix that_close
won't be run ifmainHandler
throws an exception.