search

haskell-grpc-native / http2-client

A native HTTP2 client in Haskell
BSD 3-Clause "New" or "Revised" License
43 stars 27 forks source link

Support `http2` 4.2 #89

Closed 9999years closed 6 months ago

TristanCacqueray commented 9 months ago

Perhaps this could jump to http2 version 5?

Miezhiko commented 9 months ago

I have additional patch needed, feel free to add/use it

--- a/src/Network/HTTP2/Client/Channels.hs
+++ b/src/Network/HTTP2/Client/Channels.hs
@@ -11,12 +11,14 @@ module Network.HTTP2.Client.Channels (

 import           Control.Concurrent.Chan.Lifted (Chan, readChan, newChan, writeChan)
 import           Control.Exception.Lifted (Exception, throwIO)
-import           Network.HTTP2.Frame (StreamId, FrameHeader, FramePayload, FrameType, framePayloadToFrameType, streamId)
+import           Network.HTTP2.Frame (StreamId, FrameHeader, FramePayload, FrameType, FrameDecodeError, framePayloadToFrameType, streamId)

 import           Network.HTTP2.Client.Exceptions

 type FramesChan e = Chan (FrameHeader, Either e FramePayload)

+instance Exception FrameDecodeError
+
 whenFrame
   :: Exception e
   => (FrameHeader -> FramePayload -> Bool)
ProofOfKeags commented 6 months ago

I'm not sure what to do with this PR given that it is in draft.

Miezhiko commented 6 months ago

I'm not sure what to do with this PR given that it is in draft.

with merging #91 (same authorship, same commits + my fix) this one could be closed