adding FromField and ToField instances for UTCTime

haskell-hvr / cassava

A CSV parsing and encoding library optimized for ease of use and high performance

http://hackage.haskell.org/package/cassava

BSD 3-Clause "New" or "Revised" License

223 stars 107 forks source link

adding FromField and ToField instances for UTCTime #151

Open mherzl opened 7 years ago

mherzl commented 7 years ago

Hi,

I appreciate your cassava repo.

Including these FromField and ToField instances for time's UTCTime would be useful to me.

Please feel free to let me know if I can be of help in getting this feature included.

Thank you! Matthew

ocramz commented 6 years ago

@mherzl @hvr it seems like hvr/cassava is not in Travis anymore? I therefore can't see why this PR failed.

hvr commented 6 years ago

@ocramz the logs for this PR moved to https://travis-ci.org/haskell-hvr/cassava/builds/264861856

However, I'm not convinced this PR to be non-controversial enough at this point. At the very least I'd expect a canonical ISO8601 based serialisation (including a timezone designation, like a trailing Z) that is able to round-trip UTCTime in a loss-less way and is able to deserialise time-zoned ISO8601 representations reasonably.