search

haskell-hvr / cassava

A CSV parsing and encoding library optimized for ease of use and high performance
http://hackage.haskell.org/package/cassava
BSD 3-Clause "New" or "Revised" License
222 stars 105 forks source link

flag bytestring--LT-0_10_4 default #183

Closed robwithhair closed 2 years ago

robwithhair commented 4 years ago

https://github.com/haskell-hvr/cassava/blob/5996d4f6c6a88dbb77788d7583ed6f1c1ed90b38/cassava.cabal#L53

This flag is locking ByteString package down to 0.10.4 by default. This is beginning to create problems with other packages. Tests pass when this flag is set to false. Should this flag be default be false?

Not knowing the history of this flag it is difficult for me to know how to set it. Perhaps the documentation needs an update with a more full description to avoid future user confusion?

andreasabel commented 2 years ago

Should this flag be default be false?

Yes, absolutely!

andreasabel commented 2 years ago

Fix by 0.5.2.0-r6: https://hackage.haskell.org/package/cassava-0.5.2.0/revisions/