haskell-hvr / cassava

A CSV parsing and encoding library optimized for ease of use and high performance
http://hackage.haskell.org/package/cassava
BSD 3-Clause "New" or "Revised" License
222 stars 105 forks source link

Allow bytestring-0.11 + QuickCheck-2.14 #190

Closed Bodigrim closed 3 years ago

Bodigrim commented 3 years ago

Tested using

packages: .
tests: True

constraints:
  bytestring >= 0.11

source-repository-package
  type: git
  location: https://github.com/haskell/attoparsec

allow-newer:
  regex-base:bytestring,
  regex-posix:bytestring,
  uuid-types:bytestring,
  text-short:bytestring
bergmark commented 3 years ago

As a hackage trustee i filed http://hackage.haskell.org/package/cassava-0.5.2.0/revisions/ for this.

JivanRoquet commented 3 years ago

I've added cassava-0.5.2.0@rev:4 to extra-deps in stack.yaml but I still get the same error as before:

In the dependencies for cassava-0.5.2.0:
    bytestring-0.10.12.0 from stack configuration does not match >=0.9.2 && <0.10.4  (latest matching version is 0.10.2.0)
needed due to myproj-0.1.0.0 -> cassava-0.5.2.0

Is it necessary to somehow "purge" the previously downloaded version of cassava in order to have the revision taken into account?

Bodigrim commented 3 years ago

Hard to tell exactly without seeing your stack.yaml, but usually it means that you need to remove allow-newer: true.

JivanRoquet commented 3 years ago

I'm not using allow-newer here

Bodigrim commented 3 years ago

If we are just having a small talk, that's fine, but if you are seeking help, providing your stack.yaml would be of utmost importance.

JivanRoquet commented 3 years ago

@Bodigrim sorry about that, you're absolutely right

local-bin-path: ./build/

resolver:
  url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/17/10.yaml

packages:
- .

extra-deps:
  - hspec-core-2.7.10
  - hspec-discover-2.7.10
  - hspec-2.7.10
  - text-1.2.4.1
  - scotty-0.12
  - wai-3.2.3
  - wai-extra-3.1.6
  - aeson-1.5.6.0
  - aeson-casing-0.1.0.2
  - hedis-0.14.2
  - bytestring-0.10.12.0
  - random-1.1
  - split-0.2.3.4
  - scientific-0.3.6.2
  - postgresql-simple-0.6.4
  - string-interpolate-0.3.1.0
  - csv-0.1.2
  - filepath-1.4.2.1
  - cassava-0.5.2.0@rev:4

Here the last item in extra-deps is the one that causes the issue. Adding the @rev:4 seems to have no effect, everything goes as if I was not specifying a revision.

Bodigrim commented 3 years ago

Adding @rev:4 has no effect indeed: lts-17.10 ships cassava-0.5.2.0@rev:4 by default (https://www.stackage.org/package/cassava/snapshots). And many other extra-deps are present in lts-17.10 as well. What was the reason to declare them manually?

Is your stack up to date? stack --version Is the output above from stack build or from something else?

JivanRoquet commented 3 years ago

@Bodigrim thanks for pointing this out, I guess I was just confused by how Stack works in general. Now it's much clearer.

Bodigrim commented 3 years ago

This does not look getting merged any time soon, closing.