search

haskell-hvr / hslogger

Logging framework for Haskell
https://hackage.haskell.org/package/hslogger
BSD 3-Clause "New" or "Revised" License
64 stars 36 forks source link

Fix compilation for GHC 7.10 #28

Closed alanz closed 9 years ago

Daniel-Diaz commented 9 years ago

I was going to write exactly this patch. I hope it gets merged soon. Thanks @alanz.

hesselink commented 9 years ago

Thanks for working on this! I don't think you should use the __GLASGOW_HASKELL__ macro for this, since this is not a problem with new GHC versions, but with new time versions. You can use MIN_VERSION_time(1,5,0) instead, which is defined by cabal.

Daniel-Diaz commented 9 years ago

I agree with @hesselink.

bgamari commented 9 years ago

I've opened #29 which implements the cleaner MIN_VERSION approach.

alanz commented 9 years ago

Ok, I did update my original based on this feedback.

On Fri, Feb 6, 2015 at 5:40 AM, Ben Gamari notifications@github.com wrote:

I've opened #29 https://github.com/jgoerzen/hslogger/pull/29 which implements the cleaner MIN_VERSION approach.

— Reply to this email directly or view it on GitHub https://github.com/jgoerzen/hslogger/pull/28#issuecomment-73178334.