search

haskell-hvr / hslogger

Logging framework for Haskell
https://hackage.haskell.org/package/hslogger
BSD 3-Clause "New" or "Revised" License
64 stars 36 forks source link

time-1.5 compatibility #29

Closed bgamari closed 9 years ago

bgamari commented 9 years ago

The time package now exposes its own TimeLocale.

nikomi commented 9 years ago

Nice fix!

The upper limit on time needs to be removed in the cabal file though.

bgamari commented 9 years ago

@nikomi as far as I can tell there are not bounds on time (which is itself a bit problematic). Are you seeing something I'm not?

nikomi commented 9 years ago

In hslogger.cabal of version 1.2.6 on Hackage I see the following:

if flag(small_base)
    build-depends: base >= 4 && < 5, containers, directory, process,
        time < 1.5, old-locale
else

I believe this < 1.5 needs to be removed when applying this pull request. The else part describes dependencies for base < 3 - I don't think that path needs to be changed.

Since the pull request commit does not seem to mention an update to hslogger.cabal I thought I'd better mention it.

bgamari commented 9 years ago

@nikomi ahh, right. Unfortunately the latest Hackage release hasn't been pushed to the repository so there's really no way to fix this at the moment.

nikomi commented 9 years ago

No prob - it should just be remembered when the pull request is merged.