search

haskell-hvr / hslogger

Logging framework for Haskell
https://hackage.haskell.org/package/hslogger
BSD 3-Clause "New" or "Revised" License
64 stars 36 forks source link

fixes #34; removed tabs in code; fixes deprecation warning #36

Closed nd2s closed 8 years ago

nd2s commented 8 years ago

would be good if someone could test fix for #34 just to be sure. looks good on my sys, though.

nd2s commented 8 years ago

Also exported SyslogHandler to be able to write type signatures (needed for writing log formatters).

jgoerzen commented 8 years ago

I reverted 71007bde29168c10ba26d8b9e3d7b4367009c0fc because it was not compiling on Debian jessie. If you want to do this with a versioned bounds test with a preprocessor directive, I would apply that.

nd2s commented 8 years ago

Not compiling because the module is not found?

How about requiring mtl-2.2.1 in the cabal file instead? That version is from June 2014, if Debian can't keep their packages updated it's their problem. For development people use stack (or cabal-install) anyway and don't rely on the OS package management.

jgoerzen commented 8 years ago

Debian jessie ships with mtl 2.1.2. I do not at all like the idea of breaking things just for the sake of breaking them. As I said, a versioned bounds test would be fine with me. This is a pretty common compatibility device all over. I'm not going to intentionally inflict breakage on people for the sake of avoiding a warning.