The 'buildtests' flag is redundant

haskell-hvr / hslogger

Logging framework for Haskell

https://hackage.haskell.org/package/hslogger

BSD 3-Clause "New" or "Revised" License

64 stars 36 forks source link

The 'buildtests' flag is redundant #40

Closed peti closed 8 years ago

peti commented 8 years ago

The Cabal flag buildtests duplicates the exact same functionality as the --enable-tests flag to cabal. Unless I'm missing something, I believe you could just remove that without losing any functionality.

jgoerzen commented 8 years ago

You are right. That flag didn't exist when that cabal file was written. The change was pulled as part of adf61ef9c502d2fbb8c70af0363de5ac0bf0c275

grayjay commented 8 years ago

Should this issue be reopened?

peti commented 8 years ago

Also, what is adf61ef9c502d2fbb8c70af0363de5ac0bf0c275? It's not a commit in this repository, apparently.