search

haskell-hvr / missingh

Utility library [Haskell]
https://hackage.haskell.org/package/MissingH
Other
87 stars 40 forks source link

Adds support for unix-2.7.0 (included in GHC 7.8) #19

Closed argiopetech closed 10 years ago

argiopetech commented 11 years ago

The Terminated constructor of ProcessStatus in unix-2.7.0.0 includes a second argument of type Bool which indicates whether or not a coredump was created. This patch adds support for that flag via the use of MIN_VERSION_unix macros.

hvr commented 10 years ago

@jgoerzen when do you plan to upload a new package which works with GHC 7.8.1(RC2)?

jgoerzen commented 10 years ago

I will try to get to that Monday.

John

On 03/05/2014 09:44 AM, Herbert Valerio Riedel wrote:

@jgoerzen https://github.com/jgoerzen when do you plan to upload a new package which works with GHC 7.8.1(RC2)?

— Reply to this email directly or view it on GitHub https://github.com/jgoerzen/missingh/pull/19#issuecomment-36755450.

jgoerzen commented 10 years ago

Sorry for the delay. I looked at this today and it doesn't cleanly apply anymore. It appears to have been obsoleted by 25af43517e63e18d3d75a07e66f6ebbfebb6f3fb. Can you confirm?

argiopetech commented 10 years ago

Not a worry. Everything builds cleanly on 7.8.[123] now, which is all it takes to make me happy.

I tend to concur regarding the obsolescence of this patch. I did note that the existing version doesn't tell you if a core has been dumped, though I'm not sure how useful that was to begin with.

jgoerzen commented 10 years ago

Thanks Elliot! If you want the core-dump feature, could you send a new, clean pull request?

argiopetech commented 10 years ago

I don't have a particular use for it (it was more of a, "may as well use this since it's available now" thing), but since I've already done the work I may as well.

I'll take a look and get another pull request in today or tomorrow. On Oct 28, 2014 9:16 AM, "John Goerzen" notifications@github.com wrote:

Thanks Elliot! If you want the core-dump feature, could you send a new, clean pull request?

— Reply to this email directly or view it on GitHub https://github.com/jgoerzen/missingh/pull/19#issuecomment-60752892.