haskell-hvr / missingh

Utility library [Haskell]
https://hackage.haskell.org/package/MissingH
Other
87 stars 40 forks source link

Drop splitWS in favor of words from Prelude #40

Closed el-hult closed 2 years ago

el-hult commented 7 years ago

According to Hoogle, the Prelude function words link splits on all chars that are the isSpace class of whitespaces link

Comparing source code for spitWS from MissingH says that it splits on exactly the same chars. To keep one single idiomatic way to write this, I think you should drop this from the library or at least give some motivation in the docs for why to keep it.

andreasabel commented 2 years ago

I think words splits on unicode category isChar, while splitWs only splits on ASCII whitespace characters. Do you still insist it be removed?

el-hult commented 2 years ago

I buy that. Well spotted distinction.