search

haskell-hvr / regex-tdfa

Pure Haskell Tagged DFA Backend for "Text.Regex" (regex-base)
http://hackage.haskell.org/package/regex-tdfa
Other
36 stars 9 forks source link

Consider using package enummapset #6

Closed Mikolaj closed 2 years ago

Mikolaj commented 4 years ago

Moving over old issue. :)

https://github.com/ChrisKuklewicz/regex-tdfa/issues/19

andreasabel commented 2 years ago

I looked at this issue. The PR https://github.com/ChrisKuklewicz/regex-tdfa/pull/20 isn't organized well, mixing whitespace and other changes with the refactoring in one commit, so I do not know whether one cannot cherry-pick the commit easily.

Is it worth doing this refactoring? I mean, never change a running system. The hand-rolled reimplementations in regex-tdfa are thin wrappers of containers, so, likely correct.

The point of the refactoring would be to add regex-tdfa as a user to enummapset. Is there still interest (and willingness to contribute a PR from the enummapset maintainers' side, @Mikolaj )?

Mikolaj commented 2 years ago

I'm afraid I've lost touch with enummapset to a large extent, maintaining passively right now, so not really. But thank you for asking. Shall we close?

andreasabel commented 2 years ago

I think if someone wants to do this as an exercise, it is ok, but it is definitely very low prio atm. Closing, to be reopened if there is a good reason to switch to enummapset.