search

haskell-hvr / uuid

A Haskell library for creating, printing and parsing UUIDs
http://hackage.haskell.org/package/uuid
61 stars 38 forks source link

Introduce an Arbitrary instance for UUIDs. #29

Closed jessekempf closed 7 years ago

jessekempf commented 7 years ago

I also took the liberty of doing a semver version bump.

hvr commented 7 years ago

Thanks for submitting this PR, but unfortunately I'm rather reluctant to add dependencies to uuid-types as uuid-types was split off from uuid for the very purpose to have minimal dependencies. Moreover, arbitrary instances aren't considered essential enough to be defined in core packages and therefore tend to be provided as orphan instances in companion packages (see e.g. https://hackage.haskell.org/package/quickcheck-instances); ideally those instances would be provided as non-orphans by the QuickCheck package, but that comes with its own costs. I wouldn't be surprised if there is already such a package (providing an Arbitrary instance for UUID) on Hackage.

hvr commented 7 years ago

an Arbitrary instance is now available in https://hackage.haskell.org/package/quickcheck-instances-0.3.14