search

haskell-infra / hackage-trustees

Issue tracker for Hackage maintainance and trustee operations
https://hackage.haskell.org/packages/trustees/
42 stars 7 forks source link

json-builder is broken from GHC-8.4 onwards. #170

Closed AndreasPK closed 6 years ago

AndreasPK commented 6 years ago

How and when was the maintainer for the package requiring action contacted?

About 4 Months ago: https://github.com/lpsmith/json-builder/issues/2

There is also an open pull request with a fix for almost as long. https://github.com/lpsmith/json-builder/pull/3

Edit: I've also emailed the Author on the 21st of July. Without a response so far.

If available, a link to the filed issue in the upstream issue tracker

^

How critical is this, what's the impact of this breakage? E.g. how many dependent packages are affected by this? Which GHC versions are affected?

This breaks all dependent packages using GHC-8.4 or newer. I noticed it because it breaks aesons benchmarks.

hvr commented 6 years ago

@AndreasPK are you asking for an NMU?

AndreasPK commented 6 years ago

are you asking for an NMU?

That seems like the best option to me yes.

phadej commented 6 years ago

@AndreasPK out of curiosity, where you use json-builder, and can't you move to use aeson's toEncoding. If not, why?

(Asking, so we can be fair to hastache users!)

AndreasPK commented 6 years ago

@AndreasPK out of curiosity, where you use json-builder, and can't you move to use aeson's toEncoding. If not, why?

I use it transitivly be running aeson benchmarks.

Maybe using toEncoding is a valid replacement, maybe it's not. I honestly don't know.

I'm in the process of benchmarking a change to GHC, and for this I am trying to run benchmarks from various core/popular Haskell packages. If there are easy fixes I do try to upstream the changes I make to get benchmarks to run. But rewriting the inner workings of broken benchmarks is just not feasible in terms of time investment.

phadej commented 6 years ago

FWIW, PR mentioned breaks package for pre-GHC-8.0 . I'd like to see something like https://github.com/bos/text-format/pull/23/files

gwils commented 6 years ago

I have made metadata revisions so that no current version of json-builder will try to build on GHC 8.4 or above.

phadej commented 6 years ago

I made a PR to aeson so benchmarks comparing withjson-builder` are not compiled with more recent GHC.