search

haskell-infra / hackage-trustees

Issue tracker for Hackage maintainance and trustee operations
https://hackage.haskell.org/packages/trustees/
42 stars 7 forks source link

cpphs 1.20.9 fails to build with GHC 7.8.4 #255

Closed vmchale closed 4 years ago

vmchale commented 4 years ago

Build failure:

vanessa@vanessa-desktop ~/git-builds/junk/cpphs-1.20.9 🌸 cabal build -w ghc-7.8.4
Build profile: -w ghc-7.8.4 -O1
In order, the following will be built (use -v for more details):
 - cpphs-1.20.9 (lib:cpphs, exe:cpphs) (first run)
Preprocessing executable 'cpphs' for cpphs-1.20.9..
Building executable 'cpphs' for cpphs-1.20.9..
[ 7 of 12] Compiling Language.Preprocessor.Cpphs.MacroPass ( Language/Preprocessor/Cpphs/MacroPass.hs, /home/vanessa/git-builds/junk/cpphs-1.20.9/dist-newstyle/build/x86_64-linux/ghc-7.8.4/cpphs-1.20.9/build/cpphs/cpphs-tmp/Language/Preprocessor/Cpphs/MacroPass.o )

Language/Preprocessor/Cpphs/MacroPass.hs:35:38:
    Module ‘Data.Time.Format’ does not export ‘defaultTimeLocale’

Tries to build against time 1.4.2, perhaps it needs a stricter bound?

vanessa@vanessa-desktop ~/git-builds/junk/cpphs-1.20.9 🌸 cabal-plan info | rg 'time'
 │  ├─ time-1.4.2
 │     └─ time-1.4.2 ┄┄
 └─ time-1.4.2 ┄┄
 └─ time-1.4.2 ┄┄
UnitId "time-1.4.2-9b3076800c33f8382c38628f35717951"
  time-1.4.2
  time-1.4.2
phadej commented 4 years ago

Could you try to contact @malcolmwallace by email. I don't think dropping support for older GHCs was deliberate, but maybe it was. The diff between cpphs-1.20.8 and cpphs-1.20.9 is just about dropping the old-locale dependency.

This is a bit tricky, as cpphs probably want to avoid using {-# LANGUAGE CPP #-} in own code, but the compat shim is doable without too.

phadej commented 4 years ago

Revision made.