search

haskell-infra / hackage-trustees

Issue tracker for Hackage maintainance and trustee operations
https://hackage.haskell.org/packages/trustees/
42 stars 7 forks source link

readline needs a Setup.hs tweak #268

Closed clinty closed 2 years ago

clinty commented 4 years ago

readline needs defaultUserHooks changed to simpleUserHooks or defaultMainWithHooks changed to defaultMain to work with newer Cabal

phadej commented 4 years ago

This change would require NMU, please proceed with the process described as in https://github.com/haskell-infra/hackage-trustees/blob/master/policy.md#3-source-changes-simple-patches

If that is too heavy for you, there is haskeline (bundled with GHC) is an alternative you can migrate to.

phadej commented 4 years ago

readline would also need to use autogen-includes (look for similar issue with time).

phadej commented 4 years ago

After making relevant change (removing generated file from install-includes, which is not proper fix), the readline compiles fine.

                  8.10.1  8.8.3  8.6.5  8.4.4  8.2.2  8.0.2  7.10.3  7.8.4  7.6.3  7.4.2  7.2.2  7.0.4
readline-1.0.3.0  OK      OK     OK     OK     OK     OK     OK      OK     OK     OK     OK     OK   
readline-1.0.2.0  OK      OK     OK     OK     OK     OK     OK      OK     OK     OK     OK     OK   
readline-1.0.1.0  NO-IP   NO-IP  NO-IP  NO-IP  NO-IP  NO-IP  NO-IP   NO-IP  NO-IP  OK     OK     OK

IIRC that what causes https://matrix.hackage.haskell.org/#/package/readline failures (and the fact that on some builders libreadline-dev is not installed.

andreasabel commented 3 years ago

@clinty @phadej Is this issue fixed?

andreasabel commented 2 years ago

Closing for lack of interest/activity... Welcome to reopen with new information.