search

haskell-infra / hackage-trustees

Issue tracker for Hackage maintainance and trustee operations
https://hackage.haskell.org/packages/trustees/
42 stars 7 forks source link

basement does not build under GHC 9.0, PRs with fixes are ignored #284

Closed ethercrow closed 3 years ago

ethercrow commented 3 years ago

basement and foundation libraries have quite many reverse dependencies, e.g. via cryptonite and http-client-tls or gauge. However, they seem abandoned, there was only one commit in 2020, PRs and issues are ignored.

PRs with fixes for GHC 9.0: https://github.com/haskell-foundation/foundation/pull/540 by @utdemir https://github.com/haskell-foundation/foundation/pull/537 by @sgraf812 https://github.com/haskell-foundation/foundation/pull/535 by @andrewthad

sgraf812 commented 3 years ago

Summoning the owner @vincenthz to be part of the discussion

phadej commented 3 years ago

Is GHC-9.0 released already?

expipiplus1 commented 3 years ago

Might be worth pinging all the people on this page https://github.com/haskell-foundation

expipiplus1 commented 3 years ago

I emailed @vincenthz about this about a week ago and didn't get a reply.

Bodigrim commented 3 years ago

(Could this be a lesson to learn about custom preludes?..)

vincenthz commented 3 years ago

PR and issues on unreleased ghc is not my concerns anymore, this will wait until I can get 9.0 on my system (apparently 9.0 release today ..).

@Bodigrim what about a lesson for ghc in not breaking core APIs gratuitously (even "internal APIs") ?

bergmark commented 3 years ago

I think it's fair if maintainers want to wait with releases until a new GHC ships. Since this requires code changes outside of revisions I don't think it would be appropriate for us trustees to go against the maintainers wishes and perform a non-maintainer upload.

bergmark commented 3 years ago

I'm cleaning up the issue tracker a bit so I'll close this nothing that GHC 9 is out now, and hoping this will get sorted without trustee involvement.

mightybyte commented 3 years ago

FWIW, I agree with @vincenthz. It's unreasonable to expect maintainers to make changes to their packages to accommodate unreleased GHC versions and not something that trustees should deal with. If you want to live on the bleeding edge, you're gonna have to put in some work to do so.

ethercrow commented 3 years ago

FWIW, I agree with @vincenthz. It's unreasonable to expect maintainers to make changes to their packages to accommodate unreleased GHC versions and not something that trustees should deal with. If you want to live on the bleeding edge, you're gonna have to put in some work to do so.

I created this issue because the bleeding edge people have already done most of the work in those PRs and there was not even an acknowledgement. Contrast it with the situation in hashable: https://github.com/haskell-unordered-containers/hashable/pull/189#issuecomment-675891453. A maintainer said that he would look at it when GHC 9.0 is closer to release, it was completely fine.

bergmark commented 3 years ago

@ethercrow I don't think it's fair to expect a maintainer to respond to every issue filed, what you should expect is what is available at https://github.com/haskell-foundation/foundation/blob/master/LICENSE, everything else is gravy.

This probably sounds rude, but that's not my intention! Vincent has done tons of work for the community and anyone using his libraries ought to be thankful. At least that's what I think.

if we turn complaints into cheers I think we will have a much better outcome.